Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve ci and docker's env #12

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

prisca-c
Copy link
Owner

@prisca-c prisca-c commented Nov 3, 2024

Description

PR aims to improve CI by running Docker container to be closer to prod environment.

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Documentation update (changes or updates to documentation)

How Has This Been Tested?

  • Manual testing

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@prisca-c prisca-c force-pushed the feat/improve_ci_env branch 28 times, most recently from 17f8540 to 55fbb79 Compare November 5, 2024 23:10
@prisca-c prisca-c force-pushed the feat/improve_ci_env branch 3 times, most recently from fc4d825 to e4a1f43 Compare November 5, 2024 23:19
@prisca-c prisca-c marked this pull request as ready for review November 5, 2024 23:23
@prisca-c prisca-c merged commit be0f7bd into develop Nov 5, 2024
4 checks passed
@prisca-c prisca-c deleted the feat/improve_ci_env branch November 5, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant