Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created an Makefile to run the projects #6

Closed
wants to merge 2 commits into from

Conversation

Suvendu-UI
Copy link

@Suvendu-UI Suvendu-UI commented Oct 25, 2024

Description

Added a Makefile which will initialise the project by just doing commands make build make watch make clean make run

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual testing

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Related Issues

Fixes #5

@prisca-c prisca-c self-assigned this Oct 25, 2024
@prisca-c prisca-c self-requested a review October 25, 2024 19:17
Copy link
Owner

@prisca-c prisca-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi , first of all, thanks for taking your time for this PR !

I think there's some missunderstanding about the issue #5 .
What's needed is to run the "How to run" part of the readme and include in it the migration and the seed part .
Also we dont need to touch any of the tsc config file since we're using Adonis framework and it already provide a config file to extend from it.
There's 2 last issues here, you pushed dist folder, could be good to add it to .gitignore and also here we're using PNPM (which can be easily used if you got latest node), i do not mind if you're using another package, but would be good not to push package-lock.json (if you're updating or adding a new package you'll have to run PNPM install to update pnpm-lock.json, if not CI will break because package will not be up to date).

@Suvendu-UI Suvendu-UI closed this by deleting the head repository Oct 26, 2024
@prisca-c
Copy link
Owner

@Suvendu-UI You closed the PR, will you still be working on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] : Makefile to init the project
2 participants