Cockroach CI integration #2423
Merged
Cockroach CI integration #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ach_ci_integration
Use correct user.
…ach_ci_integration
dpetrick
commented
Nov 25, 2021
Weakky
approved these changes
Nov 26, 2021
|
|
||
| networks: | ||
| databases: | ||
| databases: null |
There was a problem hiding this comment.
I saw the same change on the engineer PR and should've asked before: what does this do?
There was a problem hiding this comment.
it's just the plugin autocompleting the correct key now. It was always implicitly null, just explicit now.
This was referenced Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known Prisma Cockroach limitations:
gt,gte,lt,lte: Not working, missing JSON comparators sql: jsonb comparator operators are not implemented cockroachdb/cockroach#49144Json[]type does not work.setworks,pushdoesn't (missing concat in CDB sql: enum array concatenation operator||not implemented cockroachdb/cockroach#71388)MoneyandXmlnative type./operator perform integer division cockroachdb/cockroach#41448)