-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for text in link fields #23
Conversation
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 83.39% 83.55% +0.15%
==========================================
Files 82 82
Lines 1060 1070 +10
Branches 234 241 +7
==========================================
+ Hits 884 894 +10
Misses 120 120
Partials 56 56 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here! I suggested quite a few changes, but they should be relatively quick to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @dani-mp's small change for the unit:watch
script would be nice to include if possible.
* support link text with boolean config * update prismic-client * chore(release): 0.3.8-alpha.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just something weird happened with the whitespace in one file. This can be merged and published.
src/value/contentRelationship.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird indeed, i've put them back
…-in-links # Conflicts: # CHANGELOG.md # package-lock.json # package.json # test/snapshots/lib-buildMockGroupFieldMap.test.ts.snap # test/snapshots/model-link.test.ts.snap # test/snapshots/model-linkToMedia.test.ts.snap # test/snapshots/value-image.test.ts.snap # test/snapshots/value-link.test.ts.md # test/snapshots/value-link.test.ts.snap # test/snapshots/value-linkToMedia.test.ts.md # test/snapshots/value-linkToMedia.test.ts.snap # test/snapshots/value-sharedSlice.test.ts.snap # test/snapshots/value-sharedSliceVariation.test.ts.snap # test/snapshots/value-slice.test.ts.snap
Resolves: DT-2261
Description
Adds support for the display text property in link fields.
Checklist
Preview
N/A
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩