fix(helpers): add missing dir
attribute for right-to-left languages
#211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://prismic-team.slack.com/archives/C014VAACCQL/p1729780207755199
Description
This PR updates the default richtext serializer to honor the
direction
property of rich text nodes and adds the appropriatedir
attribute on right-to-left text nodes.undefined
should serialize to "no attribute" in React according to the types.P.S. Are we considering releasing a major of this kit to eliminate the dependency on
@prismicio/types
/@prismicio/richtext
? It's not that much of a big deal for now but might cause more issues later on.Related:
@prismicio/client
PR: fix(helpers): add missingdir
attribute for right-to-left languages prismic-client#357@prismicio/svelte
PR: fix(helpers): add missingdir
attribute for right-to-left languages prismic-svelte#24Checklist
Preview
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩