-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support link text #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the other PRs, this looks good! I left a few suggestions, none of which are blocking.
I'm going to mark the PR as "Request changes" because we should publish @prismicio/client
first and update the version here before merging. Let me know if you'd like to handle that a different way though.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #23 +/- ##
==========================================
- Coverage 67.83% 67.39% -0.44%
==========================================
Files 18 18
Lines 914 914
Branches 1 5 +4
==========================================
- Hits 620 616 -4
- Misses 294 298 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to remember to update the package versions before merging and publishing. 🙂
Re: prismicio/prismic-react#205 (comment), fallback <slot>
values mostly already work the same way as "children" in props" ? children : text
. Svelte essentially runs .trim()
on the children, which has slightly different behavior:
<!-- These examples render `field.text` -->
<PrismicLink field={field}></PrismicLink>
<PrismicLink field={field}> </PrismicLink>
<PrismicLink field={field}> </PrismicLink>
<!-- These examples render the children as literal values -->
<PrismicLink field={field}>{undefined}</PrismicLink>
<PrismicLink field={field}>{null}</PrismicLink>
<PrismicLink field={field}>{""}</PrismicLink>
<PrismicLink field={field}>{0}</PrismicLink>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small things. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Resolves: DT-2272
Types of changes
Description
Checklist: