Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce HyperNova proving time, reduce computation in Nova&Mova compute_T method #183

Merged
merged 2 commits into from
Dec 17, 2024
Merged

reduce HyperNova proving time, reduce computation in Nova&Mova compute_T method #183

merged 2 commits into from
Dec 17, 2024

Conversation

arnaucube
Copy link
Collaborator

  • add flamegraphs to hypernova&protogalaxy benchmarks to make it a bit easier to identify bottlenecks
  • reduce ~65% proving time in HyperNova by removing the not-needed cs.finalize calls
  • update compute_T (Nova & Mova) using Mova optimized approach from Mova's section 5.2 (https://eprint.iacr.org/2024/1220.pdf)

@arnaucube arnaucube requested a review from winderica December 16, 2024 07:57
winderica
winderica approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@winderica winderica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Looks great to me!

@arnaucube arnaucube added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 659b909 Dec 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winderica winderica winderica approved these changes

Assignees
No one assigned
Labels
optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnaucube @winderica