Incorporate publisher ad quality requirements into unified stack #464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR incorporates changes made in PR#462 into the unified stack.
Additionally with this change, we will always execute sequential auctions, i.e. start with the contextual auction followed by the Protected Audience auction. Currently, we only do this for multi-seller setups. But as we start including additional signals in the auction config, the contextual pathway becomes more critical.
Affected services
Changelog
Changes to
ad-tech
contextual-bidder-router
to include any query parameter starting withsellerSignal
in the sellerSignals field of the auction config, where the sellerSignal prefix will be stripped and the remaining text is converted into camel-case. All other query parameters that don’t start withsellerSignal
will be included auctionSignals fields of the auction config.ssp-tag
to always userun-sequential-ad-auction
for the iframe document. And because the publisher'sadUnit
configuration specifiesotherSellers
, modifyrun-sequential-ad-auction.js
to explicitly include itself among all sellers.auctionConfig.sellerSignals
.KNOWN_SHOP_ITEM_TAGS_BY_ID
and map multiple creative tags toshop
items.renderURL
pattern inscoring-signals-router
: /ads/display-adsChanges to
news
unified.css
.uc-publisher-ads-req
topublisher-ad-quality-req-single-seller
, and extend this topublisher-ad-quality-req-multi-seller
.components/aside
so that they are listed on all news pages.display-ad-with-deals-multi-seller
,display-ad-with-deals-single-seller
,iframe-video-ad-multi-seller
,iframe-video-ad-single-seller
.