Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate publisher ad quality requirements into unified stack #464

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

siddharth-sahoo
Copy link
Contributor

@siddharth-sahoo siddharth-sahoo commented Nov 22, 2024

Description

This PR incorporates changes made in PR#462 into the unified stack.

Additionally with this change, we will always execute sequential auctions, i.e. start with the contextual auction followed by the Protected Audience auction. Currently, we only do this for multi-seller setups. But as we start including additional signals in the auction config, the contextual pathway becomes more critical.

Affected services

  • Home
  • News
  • Shop
  • Travel
  • Ad-tech

Changelog

Changes to ad-tech

  • Modify logic in contextual-bidder-router to include any query parameter starting with sellerSignal in the sellerSignals field of the auction config, where the sellerSignal prefix will be stripped and the remaining text is converted into camel-case. All other query parameters that don’t start with sellerSignal will be included auctionSignals fields of the auction config.
  • Modify ssp-tag to always use run-sequential-ad-auction for the iframe document. And because the publisher's adUnit configuration specifies otherSellers, modify run-sequential-ad-auction.js to explicitly include itself among all sellers.
  • Modify auction decision logic to match creative tags coming from real-time scoring signals with creative tags to be excluded coming from auctionConfig.sellerSignals.
  • Rename existing constant KNOWN_SHOP_ITEM_TAGS_BY_ID and map multiple creative tags to shop items.
  • Fix renderURL pattern in scoring-signals-router: /ads/display-ads

Changes to news

  • Modify styling statements to unified.css.
  • Rename uc-publisher-ads-req to publisher-ad-quality-req-single-seller, and extend this to publisher-ad-quality-req-multi-seller.
  • Include these new pages in components/aside so that they are listed on all news pages.
  • Apply linter fixes to display-ad-with-deals-multi-seller, display-ad-with-deals-single-seller, iframe-video-ad-multi-seller, iframe-video-ad-single-seller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant