Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network support #744

Merged
merged 13 commits into from
Nov 9, 2024
Merged

Add network support #744

merged 13 commits into from
Nov 9, 2024

Conversation

probonopd
Copy link
Owner

Closes #43
Thanks @omersiar

@probonopd
Copy link
Owner Author

@probonopd probonopd marked this pull request as draft November 7, 2024 21:27
@omersiar
Copy link

omersiar commented Nov 8, 2024

Tried to resolve the conflict from network branch.

Copy link

github-actions bot commented Nov 8, 2024

Build for testing:
MiniDexed_2024-11-08-fc85a46
Use at your own risk.

@Banana71
Copy link

Banana71 commented Nov 8, 2024

Hello Omersiar,
I'm happy to read that there may soon be a network function for the miniDexed.
How do I configure the network on the Raspberry Pi?
What should I test with version 2024_11_08_fc85a46? Have I missed any instructions?

Regards
Peter

@omersiar
Copy link

omersiar commented Nov 8, 2024

Hi,

https://github.com/omersiar/MiniDexed/releases/tag/v0.0.1

Please also follow the instruction there. mt32's wiki has useful information too.

@omersiar
Copy link

omersiar commented Nov 8, 2024

I'm sure you have pretty decent setup, so you can send midi notes for all your tracks to see if it can keep up, the implementation does not take into account the timestamps so notes can arrive late or early.

I mostly wanted to have it to test and tune sounds but full track playback should be the ultimate goal i think

@probonopd
Copy link
Owner Author

probonopd commented Nov 9, 2024

Thanks @omersiar, I will try it very soon. This is really cool.

The way I understand it, according to https://github.com/rsta2/circle/tree/master/addon/wlan/sample/hello_wlan, this might work with the on-board WLAN device of the Raspberry Pi 3, 4, 5 and Zero W (not sure about the Zero 2).

A /firmware directory must be created on the SD card and firmware files for the WLAN modules need to be put in there. I'll try to do this as part of the build process so that users won't have to think about this.

Furthermore a configuration file wpa_supplicant.conf is required in the root
directory of the SD card. Please don't forget to edit your WLAN configuration in this file.

In minidexed.ini we need

# Network
NetworkEnabled=1
NetworkDHCP=1
NetworkType=wifi

Most likely we should ship it by default as

# Network
NetworkEnabled=0
NetworkDHCP=1
NetworkType=wifi

and instruct users to change NetworkEnabled to 1 if they want to use it.

@probonopd probonopd changed the base branch from main to network November 9, 2024 08:26
@probonopd probonopd marked this pull request as ready for review November 9, 2024 08:28
@probonopd probonopd merged commit 65f7d6b into probonopd:network Nov 9, 2024
1 check passed
@probonopd
Copy link
Owner Author

Merged into a separate branch so that I can work on it; continues in #747.

probonopd added a commit that referenced this pull request Nov 9, 2024
@omersiar
Copy link

omersiar commented Nov 9, 2024

/firmware files are propriety blobs which they may not allowed to redistribute freely.

https://github.com/RPi-Distro/firmware-nonfree/blob/bookworm/debian/copyright

This fashion is more correct I think
https://github.com/rsta2/circle/blob/master/addon/wlan/firmware/Makefile

Repository owner locked and limited conversation to collaborators Nov 9, 2024
@probonopd
Copy link
Owner Author

That's what I am using; let's continue in #747.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting RTP-MIDI
3 participants