Claudine's final report #19
Conversation
|
Thanks for the final report Claudine! Tagging @Stefterv for a review before merging. |
|
Quick feedback: I'd have liked to see more about any limitations and/or known issues with the work in its current state. Similarly, a Future Goals section would be welcome. |
|
Sure, I interpreted this to be a report to consolidate all information, until I saw the reports of my fellow grantees, and I realized I might have tried to create the wrong thing. I could put this report somewhere else, and try to create a more lean and targeted report. |
|
Ok, have completely refactored the report. I think I would have benefited from a report template. :) |
|
Sorry it took me a minute to review, looks good to me! |
|
@SableRaf Is there something more missing from this PR that I need to do before it an be merged? Thanks. |
|
Ah, ok. I hadn't realized that was a request for something more. Apologies. I don't actually understand what the request is - You've just said in that comment that you "added a comment above about the documentation site" - what is the comment above? Can you remind me directly what is missing? Many thanks. |
|
Perhaps it's possible you made a comment but didn't actually send it? |
2024_NewBeginnings/final-reports/pr05_2024_final_report_Claudine_Chen.md
Outdated
Show resolved
Hide resolved
|
@mingness: My apologies! You're right. I didn't realize my review was never published. |
|
@SableRaf no problem, it makes sense now. I've included your comment into the report. Please take a look 🙏 Thank you. |
|
lgtm sorry again for the delay! |
No description provided.