Skip to content

Commit

Permalink
feat(ad-hoc): update GitHub runner (#387)
Browse files Browse the repository at this point in the history
* Bump runner to macos-15
* Bump test destination to iOS 18
* Remove unused lokalise/cli-2 homebrew dependency
  • Loading branch information
andrii-vysotskyi-cko authored Nov 13, 2024
1 parent 705079e commit 247147d
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/actions/select-xcode/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ runs:
using: "composite"
steps:
- name: Select Xcode Version
run: sudo xcode-select -s '/Applications/Xcode_16.app/Contents/Developer'
run: sudo xcode-select -s '/Applications/Xcode.app/Contents/Developer'
shell: bash
2 changes: 1 addition & 1 deletion .github/workflows/add-pod-owner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
type: string
jobs:
add-owner:
runs-on: macos-14
runs-on: macos-15
steps:
- uses: actions/checkout@v4
- name: Add Owner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
jobs:
create-release:
name: Create Release
runs-on: macos-14
runs-on: macos-15
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create_release_candidate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
- major
jobs:
update-version:
runs-on: macos-14
runs-on: macos-15
steps:
- uses: actions/checkout@v4
- name: Update Version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/push_podspecs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
workflow_dispatch:
jobs:
push-podspecs:
runs-on: macos-14
runs-on: macos-15
steps:
- uses: actions/checkout@v4
- name: Bootstrap Project
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ concurrency:
cancel-in-progress: true
jobs:
run-tests:
runs-on: macos-14
runs-on: macos-15
steps:
- uses: actions/checkout@v4
- name: Bootstrap Project
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/upload-example-to-testflight.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
workflow_dispatch:
jobs:
export:
runs-on: macos-14
runs-on: macos-15
steps:
- uses: actions/checkout@v4
- name: Select Xcode Version
Expand Down
4 changes: 0 additions & 4 deletions Brewfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
# Taps
tap "lokalise/cli-2"

brew "xcodegen"
brew "swiftlint"
brew "sourcery"
brew "lokalise2"
6 changes: 4 additions & 2 deletions Scripts/TestDestination.swift
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@ try FileHandle.standardOutput.write(contentsOf: destination)
func supportedDeviceId(attempt: Int = 0) throws -> String? {
let devices = try devices()
let supportedDevices = try runtimes()
.filter { $0.version.starts(with: "17") && $0.platform == "iOS" }
.filter { $0.version.starts(with: "18") && $0.platform == "iOS" }
.compactMap { devices[$0.identifier] }
.flatMap { $0 }
.filter { $0.name.starts(with: "iPhone") && $0.isAvailable }
// Grab last device to get the most recent iOS version
if let device = supportedDevices.last {
return device.udid
Expand All @@ -42,7 +43,8 @@ func runtimes() throws -> [Runtime] {
}

struct Device: Decodable {
let udid: String
let udid, name: String
let isAvailable: Bool
}

/// Key is Runtime ID.
Expand Down

0 comments on commit 247147d

Please sign in to comment.