Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfixes: MapperKind.MUTATION and directives running multiple times #94

Merged
merged 2 commits into from
Oct 11, 2023
Merged

bugfixes: MapperKind.MUTATION and directives running multiple times #94

merged 2 commits into from
Oct 11, 2023

Conversation

felipebergamin
Copy link
Member

@felipebergamin felipebergamin commented Sep 27, 2023 •
edited
Loading

  • Fixes directives usage on mutation arguments
  • Fixes directives validation wrapping when used by a type that appears multiple times in schema
    • this bug makes a directive validation function to run multiple times

Description

Related Issues

Progress

Pull request checklist

  • Tests: This PR includes tests for covering the features or bug fixes (if applicable).
  • Docs: This PR updates/creates the necessary documentation.
  • CI: Make sure your Pull Request passes all CI checks. If not, clarify the motif behind that and the action plan to solve it (may reference a ticket)

How to test it

Visual reference

@felipebergamin felipebergamin force-pushed the fix/directives-on-mutation-inputs branch from 8c1349a to 523d1dc Compare October 6, 2023 20:03
@felipebergamin felipebergamin force-pushed the fix/directives-on-mutation-inputs branch from 523d1dc to f3f608a Compare October 9, 2023 19:40
@felipebergamin felipebergamin changed the title fix: add MapperKind.MUTATION to createMapper fn bugfixes: MapperKind.MUTATION and directives running multiple times Oct 9, 2023
@felipebergamin felipebergamin force-pushed the fix/directives-on-mutation-inputs branch from f3f608a to 906e831 Compare October 9, 2023 19:59
@felipebergamin felipebergamin marked this pull request as ready for review October 9, 2023 20:03
DDDKnightmare
DDDKnightmare previously approved these changes Oct 9, 2023
View reviewed changes
YasminBeatriz
YasminBeatriz previously approved these changes Oct 10, 2023
View reviewed changes
@felipebergamin
fix: directives running multiple times
c6c0149 
- Add MapperKind.MUTATION to createDirectiveMapperForVisitor
- Fix a bug that makes a directive validation fn to run multiple times
when a type using the directive appears multiple times in the schema.
- Adds unit tests to cover this behavior
@felipebergamin
4.1.1
ddf8885
@felipebergamin felipebergamin force-pushed the fix/directives-on-mutation-inputs branch from 039dd4c to ddf8885 Compare October 10, 2023 19:58
@felipebergamin
Copy link
Member Author

@DDDKnightmare @YasminBeatriz I've pushed some minor changes and your approvals got dismissed 😕

@felipebergamin felipebergamin merged commit ddf8885 into master Oct 11, 2023
1 check passed
@felipebergamin felipebergamin deleted the fix/directives-on-mutation-inputs branch October 11, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DDDKnightmare DDDKnightmare DDDKnightmare approved these changes

@YasminBeatriz YasminBeatriz YasminBeatriz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felipebergamin @YasminBeatriz @DDDKnightmare