Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(esm): add exports to each directive #97

Merged
merged 1 commit into from
Dec 5, 2023
Merged

feat(esm): add exports to each directive #97

merged 1 commit into from
Dec 5, 2023

Conversation

felipebergamin
Copy link
Member

This way library users can import debug functions and types and we keep index.js clean

closes #95

Description

Related Issues

Closes #95

Progress

Pull request checklist

  • Tests: This PR includes tests for covering the features or bug fixes (if applicable).
  • Docs: This PR updates/creates the necessary documentation.
  • CI: Make sure your Pull Request passes all CI checks. If not, clarify the motif behind that and the action plan to solve it (may reference a ticket)

How to test it

Visual reference

@felipebergamin
feat(esm): add exports to each directive
4186ccb 
This way library users can import debug functions and types
and we keep index.js clean

closes #95
@felipebergamin felipebergamin marked this pull request as ready for review December 5, 2023 17:22
@felipebergamin felipebergamin merged commit 66d3c88 into master Dec 5, 2023
2 checks passed
@felipebergamin felipebergamin deleted the feat/esm-exports-debug-functions branch December 5, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DDDKnightmare DDDKnightmare DDDKnightmare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More types and functions could also be exported by lib/index.js
2 participants
@felipebergamin @DDDKnightmare