Feat(#19): add table UI #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfgvieira
force-pushed
the
feat/left-menu
branch
from
4ef873a to
9a0a51d
Compare
mari1912
force-pushed
the
feat/add-table-ui
branch
2 times, most recently
from
824a81e to
2515d29
Compare
mari1912
force-pushed
the
feat/add-table-ui
branch
2 times, most recently
from
9b680b3 to
f224830
Compare
rfgvieira
reviewed
Jun 28, 2024
| "lightGray": '#F4F4F4', | ||
| "mediumGray": '#EAEAEA', | ||
| "darkGray": '#D6D6D6', | ||
| "black": '#000000' |
There was a problem hiding this comment.
this color already exists, dark color has the same value as black
There was a problem hiding this comment.
could you separate this change from this commit?
rfgvieira
force-pushed
the
feat/left-menu
branch
from
9a0a51d to
bb0f90d
Compare
| @@ -71,7 +71,7 @@ const LateralMenu = (): JSX.Element => { | |||
| orientation="vertical" | |||
| > | |||
| <div className="w-full px-4"> | |||
| <img src="./src/assets/kernelCI_logo.png"className="size-14 text-onSecondary" /> | |||
| <img src="./src/assets/kernelCI_logo.png"className="size-14 text-white" /> | |||
There was a problem hiding this comment.
why does an img have a text style?
Comment on lines
90
to
93
| BaseTable({ | ||
| headers: treeTableColumns, | ||
| body: <>{treeTableBody}</> | ||
| }) |
There was a problem hiding this comment.
why are you using BaseTable as a simple function and not as a component?
| @@ -20,7 +20,7 @@ const TableHeader = React.forwardRef< | |||
| HTMLTableSectionElement, | |||
| React.HTMLAttributes<HTMLTableSectionElement> | |||
| >(({ className, ...props }, ref) => ( | |||
| <thead ref={ref} className={cn("[&_tr]:border-b", className)} {...props} /> | |||
| <thead ref={ref} className={cn("[&_tr]:border-b border-darkGray", className)} {...props} /> | |||
There was a problem hiding this comment.
Let's try not to modify the shadcn components, we can pass the style with the className prop
mari1912
force-pushed
the
feat/add-table-ui
branch
from
f224830 to
cdd9a5b
Compare
lfjnascimento
approved these changes
Jun 28, 2024
| "lightGray": '#F4F4F4', | ||
| "mediumGray": '#EAEAEA', | ||
| "darkGray": '#D6D6D6', | ||
| "black": '#000000' |
There was a problem hiding this comment.
could you separate this change from this commit?
- add a basic table component - add a tree table component
mari1912
force-pushed
the
feat/add-table-ui
branch
from
cdd9a5b to
a43c28b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues