Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add FilterList #87

Merged
merged 2 commits into from
Jul 12, 2024
Merged

feat: add FilterList #87

merged 2 commits into from
Jul 12, 2024

Conversation

lfjnascimento
Copy link
Contributor

Description

  • update pnpm-lock.yaml
  • Create FilterButton Component
  • Add FilterButton to storybook

Closes: #69

Visual reference

image image

@lfjnascimento lfjnascimento marked this pull request as draft July 10, 2024 19:18
@lfjnascimento lfjnascimento changed the title feat: add FilterButton feat: add FilterList Jul 12, 2024
@lfjnascimento lfjnascimento force-pushed the feat/filter_buttons branch 2 times, most recently from 28b42d4 to cc80982 Compare July 12, 2024 13:19
@lfjnascimento lfjnascimento requested a review from mari1912 July 12, 2024 13:20
@lfjnascimento lfjnascimento self-assigned this Jul 12, 2024
@lfjnascimento lfjnascimento marked this pull request as ready for review July 12, 2024 13:20
interface IFilterList {
itens: string[];
onClickItem: (itemIdx: number) => void;
onClickClean: () => void;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: for me it would be better to call it onClickCleanAll

@lfjnascimento lfjnascimento merged commit 7cdb55d into main Jul 12, 2024
4 checks passed
@lfjnascimento lfjnascimento deleted the feat/filter_buttons branch July 12, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Selected Filters component
2 participants