Add option to ignore deleted campaigns. Add breaking changes to chang…

…elog
project-a · Jul 9, 2019 · 207d8cd · 207d8cd
1 parent eb9b0c9
commit 207d8cd
Show file tree

Hide file tree

Showing 3 changed files with 51 additions and 16 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,13 @@
 ## 4.0.0 (2019-07-05)
 
 - Compatible with specifications: a unique identifier is an Ad ID + Ad Group ID.
+- Add option to ignore downloading of data related to removed campaigns
+
+**required changes**
+
+- The file format changed to `v5`. Adapt etl scripts that process the output data.
+  - Ad ID no longer unique in any files
+  - Ad performance datasets now include Ad Group Id
 
 ## 3.0.0 (2019-04-13)
 

diff --git a/google_ads_downloader/config.py b/google_ads_downloader/config.py
@@ -62,3 +62,8 @@ def max_retries() -> int:
 def retry_backoff_factor() -> int:
     """How many seconds to wait between retries (is multiplied with retry count)"""
     return 5
+
+
+def ignore_removed_campaigns() -> bool:
+    """Whether to ignore campaigns with status 'REMOVED'"""
+    return False
diff --git a/google_ads_downloader/downloader.py b/google_ads_downloader/downloader.py
@@ -101,22 +101,32 @@ def download_data_sets(api_client: AdWordsApiClient):
         api_client: AdWordsApiClient
 
     """
+
+    predicates = [{'field': 'Status',
+                   'operator': 'IN',
+                   'values': ['ENABLED',
+                              'PAUSED',
+                              'DISABLED']
+                   }, {
+                      'field': 'Impressions',
+                      'operator': 'GREATER_THAN',
+                      'values': [0]
+                  }]
+
+    if config.ignore_removed_campaigns():
+        predicates.append({
+            'field': 'CampaignStatus',
+            'operator': 'NOT_EQUALS',
+            'values': 'REMOVED'
+        })
+
     download_performance(api_client,
                          PerformanceReportType.AD_PERFORMANCE_REPORT,
                          fields=['Date', 'Id', 'AdGroupId', 'Device', 'AdNetworkType2',
                                  'ActiveViewImpressions', 'AveragePosition',
                                  'Clicks', 'Conversions', 'ConversionValue',
                                  'Cost', 'Impressions'],
-                         predicates=[{'field': 'Status',
-                                      'operator': 'IN',
-                                      'values': ['ENABLED',
-                                                 'PAUSED',
-                                                 'DISABLED']
-                                      }, {
-                                         'field': 'Impressions',
-                                         'operator': 'GREATER_THAN',
-                                         'values': [0]
-                                     }]
+                         predicates=predicates
                          )
 
     download_account_structure(api_client)
@@ -316,18 +326,31 @@ def get_ad_data(api_client: AdWordsApiClient, client_customer_id: int) -> [{}]:
     logging.info('get ad data for account {}'.format(client_customer_id))
 
     api_client.SetClientCustomerId(client_customer_id)
+
+    predicates = [
+        {
+            'field': 'Status',
+            'operator': 'IN',
+            'values': ['ENABLED',
+                       'PAUSED',
+                       'DISABLED']
+        }
+    ]
+
+    if config.ignore_removed_campaigns():
+        predicates.append({
+            'field': 'CampaignStatus',
+            'operator': 'NOT_EQUALS',
+            'values': 'REMOVED'
+        })
+
     report = _download_adwords_report(api_client,
                                       report_type='AD_PERFORMANCE_REPORT',
                                       fields=['Id', 'AdGroupId', 'AdGroupName',
                                               'CampaignId', 'CampaignName',
                                               'Labels', 'Headline', 'AdType',
                                               'Status'],
-                                      predicates={'field': 'Status',
-                                                  'operator': 'IN',
-                                                  'values': ['ENABLED',
-                                                             'PAUSED',
-                                                             'DISABLED']
-                                                  })
+                                      predicates=predicates)
 
     ad_data = []
     for row in report: