Fix compiler errors about lifetime #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With
```
rustc --version
rustc 1.68.2 (9eb3afe9e 2023-03-27)
cargo --version
cargo 1.68.2 (6feb7c9cf 2023-03-26)
```
I was getting the following errors:
```
Compiling rs-matter v0.1.0 (/Users/markusbecker/src/matter-rs/rs-matter)
error[E0310]: the parameter type `D` may not live long enough
--> rs-matter/src/mdns/builtin.rs:131:5
|
131 | / {
132 | | let mut udp = crate::transport::udp::UdpListener::new(
133 | | stack,
134 | | crate::transport::network::SocketAddr::new(IpAddr::V6(Ipv6Addr::UNSPECIFIED), PORT),
... |
201 | | .unwrap()
202 | | }
| |_____^ ...so that the type `D` will meet its required lifetime bounds
|
help: consider adding an explicit lifetime bound...
|
130 | D: crate::transport::network::NetworkStackDriver + 'static,
| +++++++++
error[E0310]: the parameter type `D` may not live long enough
--> rs-matter/src/transport/core.rs:134:5
|
134 | / {
135 | | let udp = crate::transport::udp::UdpListener::new(
136 | | stack,
137 | | crate::transport::network::SocketAddr::new(
... |
200 | | .unwrap()
201 | | }
| |_____^ ...so that the type `D` will meet its required lifetime bounds
|
help: consider adding an explicit lifetime bound...
|
132 | D: crate::transport::network::NetworkStackDriver + 'static,
| +++++++++
For more information about this error, try `rustc --explain E0310`.
```
This commit applies those recommendations.
|
I don't see these errors. (I've tried latest stable - 1.71 and latest nightly - 1.73). What compiler version are you using? |
|
Ah, it is 1.68.2 - I should read more carefully! How about upgrading to 1.71? |
Ah, right. Interesting that lifetimes are not required anymore on 1.71. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
I was getting the following errors:
This commit applies those recommendations.