Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the example section of the cargo generated documentation #87

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

ssnover
Copy link
Contributor

@ssnover ssnover commented Aug 15, 2023

Added code tags so that the generated documentation is formatted directly (cargo doc --open).

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2023

CLA assistant check
All committers have signed the CLA.

@ssnover
Copy link
Contributor Author

ssnover commented Aug 15, 2023

It looks like the restyled job is using an outdated version of Rust, it isn't accepting async fn in rs-matter/src/core.rs:179.

debug    Digest: sha256:79c2280e0f35c3e27411cba65d860b98cf68dbaee60d653883090b079d6d70c1
debug    Status: Downloaded newer image for restyled/restyler-rustfmt:v1.5.2-stable
debug    error[E0670]: `async fn` is not permitted in Rust 2015
debug       --> /code/rs-matter/src/core.rs:179:9
debug        |                          
debug    179 |     pub async fn wait_changed(&self) {
debug        |         ^^^^^ to use `async fn`, switch to Rust 2018 or later
debug        |                          
debug        = help: pass `--edition 2021` to `rustc`
debug        = note: for more on editions, read https://doc.rust-lang.org/edition-guide
debug    Error writing files: failed to resolve mod `core`: cannot parse /code/rs-matter/src/core.rs

They recommend specifying the version directly to rustfmt: https://github.com/restyled-io/restyled.io/wiki/Common-Errors:-Rustfmt but I don't see where this job is defined.

@kedars kedars merged commit 4c347c0 into project-chip:main Aug 16, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants