-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup existing DW tests to run in CFO #386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you also plan to move ray_test.go and sanity_test.go? Maybe we can create a directory with name codeflare or distributed-workloads to distinguish between DW and possible future tests for other components.
My plan is to keep just CodeFlare tests in here. About Ray tests, I would use KubeRay test suite instead of existing |
@sutaakar Understand sounds good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments, otherwise LGTM.
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti, jiripetrlik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4366322
into
project-codeflare:main
Issue link
red-hat-data-services/distributed-workloads#23
Depends on project-codeflare/codeflare-common#9
What changes have been made
Moved MCAD and Ray tests for ODH into CFO repository.
This way the tests are maintained together with other e2e tests. As CFO repository is source of manifests for ODH, the tests should stay together with manifests.
Verification steps
Currently N/A. The tests require changes in codeflare-common repo. Also testing can be done using OpenShift CI, which will be implemented for ODH/CFO repo.
Checks