Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup existing DW tests to run in CFO #386

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Nov 1, 2023

Issue link

red-hat-data-services/distributed-workloads#23

Depends on project-codeflare/codeflare-common#9

What changes have been made

Moved MCAD and Ray tests for ODH into CFO repository.
This way the tests are maintained together with other e2e tests. As CFO repository is source of manifests for ODH, the tests should stay together with manifests.

Verification steps

Currently N/A. The tests require changes in codeflare-common repo. Also testing can be done using OpenShift CI, which will be implemented for ODH/CFO repo.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@sutaakar sutaakar added the testing Items related to testing label Nov 1, 2023
Copy link
Contributor

@jiripetrlik jiripetrlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also plan to move ray_test.go and sanity_test.go? Maybe we can create a directory with name codeflare or distributed-workloads to distinguish between DW and possible future tests for other components.

@sutaakar
Copy link
Contributor Author

sutaakar commented Nov 1, 2023

My plan is to keep just CodeFlare tests in here. About Ray tests, I would use KubeRay test suite instead of existing ray_test.go

@jiripetrlik
Copy link
Contributor

@sutaakar Understand sounds good to me.

Copy link
Contributor

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, otherwise LGTM.

test/odh/mcad_ray_test.go Outdated Show resolved Hide resolved
test/odh/notebook.go Show resolved Hide resolved
test/odh/pytorch_mcad_test.go Outdated Show resolved Hide resolved
@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, jiripetrlik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4366322 into project-codeflare:main Nov 13, 2023
7 checks passed
@sutaakar sutaakar deleted the dw-tests branch November 13, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm testing Items related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants