-
Notifications
You must be signed in to change notification settings - Fork 20
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add reconciler function test using envtest
Fix CRD and other issues for envtest convert test function block into multiple blocks for separate dedicated operations
- Loading branch information
1 parent
51363f6
commit 3f99ec7
Showing
4 changed files
with
190 additions
and
119 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -80,6 +80,10 @@ const ( | |
| // For more details, check Reconcile and its Result here: | ||
| // - https://pkg.go.dev/sigs.k8s.io/[email protected]/pkg/reconcile | ||
| func (r *AppWrapperReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) { | ||
| klog.Info( | ||
| "AppWrapper deleted, scaling down machineset;;;;;;;;exisecutng..............", | ||
| ) | ||
|
|
||
| _ = log.FromContext(ctx) | ||
| // todo: Move the getOCMClusterID call out of reconcile loop. | ||
| // Only reason we are calling it here is that the client is not able to make | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| package controllers | ||
|
|
||
| import ( | ||
| "context" | ||
| "go/build" | ||
| "path/filepath" | ||
| "testing" | ||
| "time" | ||
|
|
||
| . "github.com/onsi/gomega" | ||
| . "github.com/project-codeflare/codeflare-common/support" | ||
| mcadv1beta1 "github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/apis/controller/v1beta1" | ||
| mc "github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/client/clientset/versioned" | ||
| apiv1 "k8s.io/api/core/v1" | ||
| "k8s.io/apimachinery/pkg/api/resource" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/client-go/kubernetes/scheme" | ||
| "k8s.io/client-go/rest" | ||
| "k8s.io/klog" | ||
| ctrl "sigs.k8s.io/controller-runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/envtest" | ||
| ) | ||
|
|
||
| var ( | ||
| cfg *rest.Config | ||
| k8sClient client.Client // You'll be using this client in your tests. | ||
| testEnv *envtest.Environment | ||
| ctx context.Context | ||
| cancel context.CancelFunc | ||
| err error | ||
| ) | ||
|
|
||
| func startEnvTest(t *testing.T) *envtest.Environment { | ||
| test := With(t) | ||
| //specify testEnv configuration | ||
| testEnv = &envtest.Environment{ | ||
| CRDDirectoryPaths: []string{ | ||
| filepath.Join("..", "config", "crd", "bases"), | ||
| filepath.Join(build.Default.GOROOT, "pkg", "mod", "github.com", "project-codeflare", "[email protected]", "config", "crd", "bases"), | ||
| }, | ||
| } | ||
| cfg, err = testEnv.Start() | ||
| test.Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| return testEnv | ||
| } | ||
|
|
||
| func establishClient(t *testing.T) { | ||
| test := With(t) | ||
| err = mcadv1beta1.AddToScheme(scheme.Scheme) | ||
| test.Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| k8sClient, err = client.New(cfg, client.Options{Scheme: scheme.Scheme}) | ||
| test.Expect(err).NotTo(HaveOccurred()) | ||
| test.Expect(k8sClient).NotTo(BeNil()) | ||
|
|
||
| k8sManager, err := ctrl.NewManager(cfg, ctrl.Options{ | ||
| Scheme: scheme.Scheme, | ||
| }) | ||
| test.Expect(err).ToNot(HaveOccurred()) | ||
|
|
||
| instaScaleController := &AppWrapperReconciler{ | ||
| Client: k8sManager.GetClient(), | ||
| Scheme: k8sManager.GetScheme(), | ||
| // Config: cfg.InstaScale.InstaScaleConfiguration, | ||
| } | ||
| err = instaScaleController.SetupWithManager(context.Background(), k8sManager) | ||
| test.Expect(err).ToNot(HaveOccurred()) | ||
|
|
||
| go func() { | ||
|
|
||
| err = k8sManager.Start(ctrl.SetupSignalHandler()) | ||
| test.Expect(err).ToNot(HaveOccurred()) | ||
| }() | ||
|
|
||
| time.Sleep(5 * time.Second) | ||
| } | ||
|
|
||
| func teardownTestEnv(testEnv *envtest.Environment) { | ||
| if err := testEnv.Stop(); err != nil { | ||
| klog.Errorf("Error stopping test Environment : %v\n", err) | ||
| } | ||
| } | ||
|
|
||
| func TestReconciler(t *testing.T) { | ||
| testEnv = startEnvTest(t) | ||
| defer teardownTestEnv(testEnv) | ||
|
|
||
| establishClient(t) | ||
|
|
||
| app := &mcadv1beta1.AppWrapper{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "mnist", | ||
| Labels: map[string]string{ | ||
| "orderedinstance": "test.instance1_test.instance2", | ||
| }, | ||
| }, | ||
| Spec: mcadv1beta1.AppWrapperSpec{ | ||
| AggrResources: mcadv1beta1.AppWrapperResourceList{ | ||
| GenericItems: []mcadv1beta1.AppWrapperGenericResource{ | ||
| { | ||
| DesiredAvailable: 1, | ||
| CustomPodResources: []mcadv1beta1.CustomPodResourceTemplate{ | ||
| { | ||
| Replicas: 1, | ||
| Requests: apiv1.ResourceList{ | ||
| apiv1.ResourceCPU: resource.MustParse("250m"), | ||
| apiv1.ResourceMemory: resource.MustParse("512Mi"), | ||
| }, | ||
| Limits: apiv1.ResourceList{ | ||
| apiv1.ResourceCPU: resource.MustParse("1"), | ||
| apiv1.ResourceMemory: resource.MustParse("1G"), | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| mcadClient, err := mc.NewForConfig(cfg) | ||
| With(t).Expect(err).ToNot(HaveOccurred()) | ||
|
|
||
| _, err = mcadClient.WorkloadV1beta1().AppWrappers("default").Create(With(t).Ctx(), app, metav1.CreateOptions{}) | ||
| With(t).Expect(err).ToNot(HaveOccurred()) | ||
|
|
||
| time.Sleep(3 * time.Second) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.