Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instructions for scaling MachineSets in an OCP cluster with IS #142

Conversation

Bobbins228
Copy link
Contributor

Issue link

Closes #113

What changes have been made

Created a template for a MachineSet and described how to create a MachineSet in OpenShift

Verification steps

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

README.md Outdated Show resolved Hide resolved
@KPostOffice
Copy link
Contributor

/lgtm

Copy link
Contributor

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment, otherwise looks good to me.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Fiona Waters <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Sep 20, 2023
@Fiona-Waters
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Sep 22, 2023
@dimakis
Copy link
Contributor

dimakis commented Sep 22, 2023

/lgtm

@astefanutti
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2c7538e into project-codeflare:main Sep 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for scaling MachineSets
6 participants