Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rhoaieng 1094 #194

Merged
merged 1 commit into from
Jan 15, 2024
Merged

rhoaieng 1094 #194

merged 1 commit into from
Jan 15, 2024

Conversation

KPostOffice
Copy link
Contributor

@KPostOffice KPostOffice commented Jan 8, 2024 •
edited
Loading

we are no longer using gh project board for sprint planning, so I removed the gh workflow which automatically adds the issues to the project board

@openshift-ci openshift-ci bot requested review from Maxusmusti and sutaakar January 8, 2024 21:53
@sutaakar
Copy link
Contributor

sutaakar commented Jan 9, 2024

@KPostOffice Can you please adjust the PR description to be more descriptive?

@VanillaSpoon
Copy link
Contributor

Hey @KPostOffice :)
This makes sense to remove, however, maybe updating the codeflare docs here could also go alongside this issue.

@KPostOffice
Copy link
Contributor Author

Hey @KPostOffice :) This makes sense to remove, however, maybe updating the codeflare docs here could also go alongside this issue.

@VanillaSpoon project-codeflare/.github#17

Bobbins228
Bobbins228 reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 9, 2024
VanillaSpoon
VanillaSpoon approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@VanillaSpoon VanillaSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VanillaSpoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VanillaSpoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 64290bb into project-codeflare:main Jan 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobbins228 Bobbins228 Bobbins228 left review comments

@VanillaSpoon VanillaSpoon VanillaSpoon approved these changes

@Maxusmusti Maxusmusti Awaiting requested review from Maxusmusti

@sutaakar sutaakar Awaiting requested review from sutaakar

Assignees

@VanillaSpoon VanillaSpoon

@Bobbins228 Bobbins228

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KPostOffice @sutaakar @VanillaSpoon @Bobbins228 @openshift-merge-robot