[WIP]: Updated more things relating to docker #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nexus4880
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also snuck in a couple changes that should not go unnoticed:
Send the AccountId either way: this may not be needed, I was having issues with my console application launcher and this was one of the changes I made in an attempt to get it to work again (I didn't.)
Added a method to actually update the game backends: this was needed for me to be able to test properly by changing the backend host.
I need this to be available for testing the docker container: this can be uncommented or left commented. Leaving it would commented would make it easier for me to continue forward though.
Use environment variables for port hosting for now: we may want to switch to a launch argument/config system later? Honestly if Docker is the main targeted method then this is fine.