Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4306] Allow setting of additional info for Azure #480

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

cgoodfred
Copy link
Contributor

@cgoodfred cgoodfred commented Dec 6, 2023

Azure generators weren't respecting additional info being set in the yaml and always choosing randomly from the predefined choices. They now handle the current flow of a default additional info as well as additional_info being set in the yaml.

@cgoodfred cgoodfred self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #480 (92c5be1) into main (aff72e6) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #480     +/-   ##
=======================================
- Coverage   93.5%   93.5%   -0.1%     
=======================================
  Files         60      60             
  Lines       4620    4625      +5     
  Branches     662     663      +1     
=======================================
+ Hits        4321    4323      +2     
- Misses       156     158      +2     
- Partials     143     144      +1     

@cgoodfred cgoodfred marked this pull request as ready for review December 6, 2023 14:29
@cgoodfred cgoodfred merged commit d15b7ef into main Dec 6, 2023
4 checks passed
@cgoodfred cgoodfred deleted the COST-4306-set-additional-info-azure branch December 6, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants