Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST 5161] Drop azure v1 reports support #513

Merged
merged 13 commits into from
Jul 17, 2024

Conversation

bacciotti
Copy link
Contributor

@bacciotti bacciotti commented Jun 28, 2024

This change will drop v1 report fields and add v2 Resource Group based fields and Subscription fields.

In addition, it removes the --version-two flag and adds --resource-group flag (to specify that the report should be resource group based).

@bacciotti bacciotti changed the title Cost 5161 drop azure v1 reports support [COST 5161] Drop azure v1 reports support Jun 28, 2024
@bacciotti bacciotti marked this pull request as ready for review June 28, 2024 15:38
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.9%. Comparing base (e3f0922) to head (6f03f62).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #513   +/-   ##
=====================================
  Coverage   93.8%   93.9%           
=====================================
  Files         62      62           
  Lines       4699    4685   -14     
  Branches     664     664           
=====================================
- Hits        4410    4398   -12     
+ Misses       151     150    -1     
+ Partials     138     137    -1     

nise/__init__.py Outdated Show resolved Hide resolved
nise/__main__.py Show resolved Hide resolved
nise/generators/azure/__init__.py Outdated Show resolved Hide resolved
nise/generators/azure/azure_generator.py Show resolved Hide resolved
nise/generators/azure/azure_generator.py Outdated Show resolved Hide resolved
@bacciotti bacciotti requested a review from samdoran July 17, 2024 09:16
@bacciotti bacciotti merged commit d4b49e2 into main Jul 17, 2024
4 checks passed
@bacciotti bacciotti deleted the cost-5161_drop_azure_v1_reports_support branch July 17, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants