Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Savings Plan Negation #524

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Add AWS Savings Plan Negation #524

merged 3 commits into from
Aug 13, 2024

Conversation

lcouzens
Copy link
Contributor

This PR adds the ability to set AWS SavingsPlanNegation along side SavingsPlanCoveredUsage lineitems

This is added to two generators;
EC2Generator and DataTransferGenerator

Negation examples:

  • DataTransferGenerator:
    start_date: last_month
    product_sku: AERJHRNCCCCC
    product_code: AmazonDynamoDB
    product_name: Amazon DynamoDB
    amount: 5
    rate: 10
    negation: True

  • EC2Generator:
    start_date: last_month
    processor_arch: 64-bit
    product_sku: VEAJHRNKTJZB
    region: us-east-1b
    instance_type:
    inst_type: m5.large
    vcpu: "2"
    physical_cores: 1.0
    memory: '8 GiB'
    storage: 'EBS Only'
    family: 'General Purpose'
    cost: 10
    rate: 0.500
    negation: True

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.9%. Comparing base (c87c693) to head (c61ed40).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #524   +/-   ##
=====================================
  Coverage   93.8%   93.9%           
=====================================
  Files         62      62           
  Lines       4698    4714   +16     
  Branches     667     671    +4     
=====================================
+ Hits        4408    4425   +17     
  Misses       151     151           
+ Partials     139     138    -1     

@lcouzens lcouzens force-pushed the COST-5378 branch 3 times, most recently from 2d3edce to 2b1b294 Compare August 13, 2024 11:08
@lcouzens lcouzens marked this pull request as ready for review August 13, 2024 11:20
@lcouzens lcouzens merged commit 31ad6f3 into main Aug 13, 2024
4 checks passed
@lcouzens lcouzens deleted the COST-5378 branch August 13, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants