Add AWS Savings Plan Negation #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
=====================================
Coverage 93.8% 93.9%
=====================================
Files 62 62
Lines 4698 4714 +16
Branches 667 671 +4
=====================================
+ Hits 4408 4425 +17
Misses 151 151
+ Partials 139 138 -1 |
lcouzens
force-pushed
the
COST-5378
branch
3 times, most recently
from
2d3edce to
2b1b294
Compare
myersCody
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to set AWS SavingsPlanNegation along side SavingsPlanCoveredUsage lineitems
This is added to two generators;
EC2Generator and DataTransferGenerator
Negation examples:
DataTransferGenerator:
start_date: last_month
product_sku: AERJHRNCCCCC
product_code: AmazonDynamoDB
product_name: Amazon DynamoDB
amount: 5
rate: 10
negation: True
EC2Generator:
start_date: last_month
processor_arch: 64-bit
product_sku: VEAJHRNKTJZB
region: us-east-1b
instance_type:
inst_type: m5.large
vcpu: "2"
physical_cores: 1.0
memory: '8 GiB'
storage: 'EBS Only'
family: 'General Purpose'
cost: 10
rate: 0.500
negation: True