Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]: unify all notation to camelCase #114

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

Istiopaxx
Copy link
Member

Doing

TODO

  • Add decorator for Rest API using class-transformer @Expose, @Exclude, and expose with snake_case for compatibility
  • Fix tests not to test implementation, just test return value or assertion
  • Devide domain object with entity
  • Move domain requirements/logic to domain object

Notice

@Istiopaxx Istiopaxx added the 리팩토링 ⚒️ 리팩토링이 필요해요 label Jan 6, 2024
@Istiopaxx Istiopaxx self-assigned this Jan 6, 2024
@Istiopaxx Istiopaxx changed the title Refactor/domain entity [Refactor]: unify all notation to camelCase Jan 6, 2024
@Istiopaxx Istiopaxx merged commit 8345897 into master Jan 6, 2024
1 check passed
@Istiopaxx Istiopaxx deleted the refactor/domain-entity branch January 9, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
리팩토링 ⚒️ 리팩토링이 필요해요
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant