Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]: change domain class field to private and open only getter #116

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

Istiopaxx
Copy link
Member

Done

  • Change domain class private -> for not changing state of domain object
  • Open only getter -> for same purpose above
  • Move business logic to domain object
    - There was no proper domain logic to move.. maybe future domain logic would be on domain object

Doing


Notice

@Istiopaxx Istiopaxx added the 리팩토링 ⚒️ 리팩토링이 필요해요 label Jan 8, 2024
@Istiopaxx Istiopaxx self-assigned this Jan 8, 2024
@Istiopaxx Istiopaxx merged commit 3a98e42 into master Jan 8, 2024
1 check passed
@Istiopaxx Istiopaxx deleted the refactor/move-business-logic-to-domain-object branch January 9, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
리팩토링 ⚒️ 리팩토링이 필요해요
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant