WIP introduce scan_pwals thread_context for LevelDB/RocksDB Batch #639
Annotations
18 errors and 9 warnings
online_compaction_test.remove_file_safely_fails_to_remove_file:
test/limestone/compaction/online_compaction_test.cpp#L997
Expected: remove_file_safely(file) throws an exception of type std::runtime_error.
Actual: it throws nothing.
|
online_compaction_test.remove_file_safely_fails_to_remove_file:
test/limestone/compaction/online_compaction_test.cpp#L997
Expected: remove_file_safely(file) throws an exception of type std::runtime_error.
Actual: it throws nothing.
|
Build (ubuntu-22.04)
- *<https://github.com/project-tsurugi/limestone/runs/29361033957?check_suite_focus=true|[CTest] 1 test failed>*
|
Build (ubuntu-22.04)
Process completed with exit code 8.
|
Build (ubuntu-24.04)
Process completed with exit code 8.
|
Build (ubuntu-24.04)
- *<https://github.com/project-tsurugi/limestone/runs/29361034960?check_suite_focus=true|[CTest] 1 test failed>*
|
clang-diagnostic-error:
src/limestone/sortdb_wrapper.h#L90
allocation of incomplete type 'leveldb::WriteBatch'
|
clang-diagnostic-error:
src/limestone/sortdb_wrapper.h#L94
member access into incomplete type 'limestone::api::sortdb_wrapper::batch' (aka 'leveldb::WriteBatch')
|
clang-diagnostic-error:
src/limestone/sortdb_wrapper.h#L95
member access into incomplete type 'limestone::api::sortdb_wrapper::batch' (aka 'leveldb::WriteBatch')
|
clang-diagnostic-delete-incomplete:
src/limestone/sortdb_wrapper.h#L98
deleting pointer to incomplete type 'limestone::api::sortdb_wrapper::batch' (aka 'leveldb::WriteBatch') may cause undefined behavior
|
clang-diagnostic-error:
src/limestone/sortdb_wrapper.h#L102
member access into incomplete type 'limestone::api::sortdb_wrapper::batch' (aka 'leveldb::WriteBatch')
|
clang-diagnostic-error:
src/limestone/sortdb_wrapper.h#L107
member access into incomplete type 'limestone::api::sortdb_wrapper::batch' (aka 'leveldb::WriteBatch')
|
clang-diagnostic-error:
src/limestone/sortdb_wrapper.h#L113
member access into incomplete type 'limestone::api::sortdb_wrapper::batch' (aka 'leveldb::WriteBatch')
|
clang-diagnostic-error:
src/limestone/sortdb_wrapper.h#L114
member access into incomplete type 'limestone::api::sortdb_wrapper::batch' (aka 'leveldb::WriteBatch')
|
clang-diagnostic-error:
src/limestone/sortdb_wrapper.h#L121
member access into incomplete type 'limestone::api::sortdb_wrapper::batch' (aka 'leveldb::WriteBatch')
|
clang-diagnostic-error:
src/limestone/sortdb_wrapper.h#L122
member access into incomplete type 'limestone::api::sortdb_wrapper::batch' (aka 'leveldb::WriteBatch')
|
Analysis
Process completed with exit code 1.
|
Analysis
- *<https://github.com/project-tsurugi/limestone/runs/29361057365?check_suite_focus=true|[Clang-Tidy] 19 warnings>*
|
cppcoreguidelines-virtual-class-destructor:
src/limestone/dblog_scan.h#L166
destructor of 'thread_context_base' is public and non-virtual
|
cppcoreguidelines-virtual-class-destructor:
src/./limestone/dblog_scan.h#L166
destructor of 'thread_context_base' is public and non-virtual
|
cppcoreguidelines-owning-memory:
src/limestone/sortdb_wrapper.h#L98
deleting a pointer through a type that is not marked 'gsl::owner<>'; consider using a smart pointer instead
|
cppcoreguidelines-virtual-class-destructor:
src/limestone/datastore_snapshot.cpp#L133
destructor of 'sortdb_batch_context' is public and non-virtual
|
google-explicit-constructor,hicpp-explicit-conversions:
src/limestone/datastore_snapshot.cpp#L136
single-argument constructors must be marked explicit to avoid unintentional implicit conversions
|
cppcoreguidelines-pro-type-cstyle-cast:
src/limestone/datastore_snapshot.cpp#L142
do not use C-style cast to convert between unrelated types
|
google-readability-casting:
src/limestone/datastore_snapshot.cpp#L142
C-style casts are discouraged; use static_cast
|
cppcoreguidelines-pro-type-cstyle-cast:
src/limestone/datastore_snapshot.cpp#L173
do not use C-style cast to convert between unrelated types
|
google-readability-casting:
src/limestone/datastore_snapshot.cpp#L173
C-style casts are discouraged; use static_cast
|