Skip to content

Commit

Permalink
Refactor: Fixed remaining issues with private header inclusion in pub…
Browse files Browse the repository at this point in the history
…lic include files
  • Loading branch information
umegane committed Sep 5, 2024
1 parent 86b22fc commit d25d897
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 6 deletions.
1 change: 0 additions & 1 deletion include/limestone/api/datastore.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
#include <limestone/api/write_version_type.h>
#include <limestone/api/tag_repository.h>
#include <limestone/api/restore_progress.h>
#include <limestone/api/rotation_task.h>

namespace limestone::internal {
class compaction_catalog;
Expand Down
2 changes: 1 addition & 1 deletion src/limestone/datastore.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
#include <limestone/api/datastore.h>
#include "internal.h"

#include <limestone/api/rotation_task.h>
#include "rotation_task.h"
#include "log_entry.h"
#include "online_compaction.h"
#include "compaction_catalog.h"
Expand Down
2 changes: 1 addition & 1 deletion src/limestone/dblog_scan.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include "internal.h"
#include "log_entry.h"


namespace limestone::internal {
// accessing dblogdir before db start
class dblog_scan {
Expand Down Expand Up @@ -181,7 +182,6 @@ class dblog_scan {

static bool is_wal(const boost::filesystem::path& p) { return p.filename().string().rfind(log_channel_prefix, 0) == 0; }
static bool is_detached_wal(const boost::filesystem::path& p) {
std::cerr << "is_detached_wal: " << p << std::endl;
auto filename = p.filename().string();
return (filename.length() > 9 && filename.rfind(log_channel_prefix, 0) == 0);
}
Expand Down
1 change: 1 addition & 0 deletions src/limestone/log_channel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include <limestone/api/datastore.h>
#include "internal.h"
#include "log_entry.h"
#include "rotation_task.h"

namespace limestone::api {

Expand Down
2 changes: 1 addition & 1 deletion src/limestone/rotation_task.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
* limitations under the License.
*/

#include <limestone/api/rotation_task.h>
#include <limestone/api/datastore.h>
#include "rotation_task.h"

namespace limestone::api {

Expand Down
File renamed without changes.
4 changes: 2 additions & 2 deletions test/limestone/compaction/rotation_task_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
* limitations under the License.
*/

#include <limestone/api/rotation_task.h>

#include <gtest/gtest.h>
#include <limestone/api/datastore.h>
#include "test_root.h"

#include "rotation_task.h"
namespace limestone::testing {

constexpr const char* data_location = "/tmp/rotation_task_test/data_location";
Expand Down

0 comments on commit d25d897

Please sign in to comment.