clang-tidy-exception-escape

project-tsurugi · Oct 19, 2023 · f5564e7 · f5564e7
1 parent 93b4d86
commit f5564e7
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/include/limestone/api/datastore.h b/include/limestone/api/datastore.h
@@ -150,7 +150,7 @@ class datastore {
      * @param new epoch id which must be greater than current epoch ID.
      * @attention this function should be called after the ready() is called.
      */
-    void switch_epoch(epoch_id_type epoch_id) noexcept;
+    void switch_epoch(epoch_id_type epoch_id);
 
     /**
      * @brief register a callback on successful persistence
@@ -265,7 +265,7 @@ class datastore {
 
     epoch_id_type search_max_durable_epock_id() noexcept;
 
-    void update_min_epoch_id(bool from_switch_epoch = false) noexcept;
+    void update_min_epoch_id(bool from_switch_epoch = false);
 
     void check_after_ready(std::string_view func) const noexcept;
 

diff --git a/include/limestone/api/log_channel.h b/include/limestone/api/log_channel.h
@@ -73,7 +73,7 @@ class log_channel {
      * @param write_version (optional) the write version of the entry to be added. If omitted, the default value is used
      * @attention this function is not thread-safe.
      */
-    void add_entry(storage_id_type storage_id, std::string_view key, std::string_view value, write_version_type write_version) noexcept;
+    void add_entry(storage_id_type storage_id, std::string_view key, std::string_view value, write_version_type write_version);
 
     /**
      * @brief adds an entry to the current persistent session
@@ -95,7 +95,7 @@ class log_channel {
      * @note no deletion operation is performed on the entry that has been added to the current persistent session, instead,
      * the entries to be deleted are treated as if they do not exist in a recover() operation from a log stored in the current persistent session
      */
-    void remove_entry(storage_id_type storage_id, std::string_view key, write_version_type write_version) noexcept;
+    void remove_entry(storage_id_type storage_id, std::string_view key, write_version_type write_version);
 
     /**
      * @brief add an entry indicating the addition of the specified storage

diff --git a/src/limestone/datastore.cpp b/src/limestone/datastore.cpp
@@ -106,7 +106,7 @@ log_channel& datastore::create_channel(const boost::filesystem::path& location)
 
 epoch_id_type datastore::last_epoch() const noexcept { return static_cast<epoch_id_type>(epoch_id_informed_.load()); }
 
-void datastore::switch_epoch(epoch_id_type new_epoch_id) noexcept {
+void datastore::switch_epoch(epoch_id_type new_epoch_id) {
     check_after_ready(static_cast<const char*>(__func__));
 
     auto neid = static_cast<std::uint64_t>(new_epoch_id);
@@ -118,7 +118,7 @@ void datastore::switch_epoch(epoch_id_type new_epoch_id) noexcept {
     update_min_epoch_id(true);
 }
 
-void datastore::update_min_epoch_id(bool from_switch_epoch) noexcept {  // NOLINT(readability-function-cognitive-complexity)
+void datastore::update_min_epoch_id(bool from_switch_epoch) {  // NOLINT(readability-function-cognitive-complexity)
     auto upper_limit = epoch_id_switched_.load() - 1;
     epoch_id_type max_finished_epoch = 0;
 

diff --git a/src/limestone/log_channel.cpp b/src/limestone/log_channel.cpp
@@ -80,7 +80,7 @@ void log_channel::abort_session([[maybe_unused]] status status_code, [[maybe_unu
     std::abort();  // FIXME
 }
 
-void log_channel::add_entry(storage_id_type storage_id, std::string_view key, std::string_view value, write_version_type write_version) noexcept {
+void log_channel::add_entry(storage_id_type storage_id, std::string_view key, std::string_view value, write_version_type write_version) {
     log_entry::write(strm_, storage_id, key, value, write_version);
     write_version_ = write_version;
 }
@@ -90,7 +90,7 @@ void log_channel::add_entry([[maybe_unused]] storage_id_type storage_id, [[maybe
     std::abort();  // FIXME
 };
 
-void log_channel::remove_entry(storage_id_type storage_id, std::string_view key, write_version_type write_version) noexcept {
+void log_channel::remove_entry(storage_id_type storage_id, std::string_view key, write_version_type write_version) {
     log_entry::write_remove(strm_, storage_id, key, write_version);
     write_version_ = write_version;
 }