change to throw exception on I/O error; including API change (drop noexcept) #43

ban-nobuhiro · 2023-10-20T08:28:14Z

#42 では、ファイル書き込みに関するエラーを検出した際に、API 上でエラーを返す方法がないので、すべて std::abort() で落とすようにしましたが、
これを、API を変更して例外を投げるようにします。(noexcept を落とす)
entry を追加するメソッドの多くが unimplemented ですが、これらの API も同様に変更します。

shirakami 側が noexcept を前提としたコーディングをしていないので、shirakami側のソースの変更なしでコンパイルが通ることを確認しました。

関連: project-tsurugi/tsurugi-issues#363

…except)

ban-nobuhiro added 2 commits October 20, 2023 17:11

change to throw exception on I/O error; including API change (drop no…

55d76d4

…except)

drop noexcept on other unimplemented entry-adding methods

60d470b

ban-nobuhiro requested a review from t-horikawa as a code owner October 20, 2023 08:28

ban-nobuhiro merged commit bfeb72d into master Oct 24, 2023
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change to throw exception on I/O error; including API change (drop noexcept) #43

change to throw exception on I/O error; including API change (drop noexcept) #43

ban-nobuhiro commented Oct 20, 2023

change to throw exception on I/O error; including API change (drop noexcept) #43

change to throw exception on I/O error; including API change (drop noexcept) #43

Conversation

ban-nobuhiro commented Oct 20, 2023