Merge pull request #20 from project-tsurugi/fix-kvs-checkstyle-warnings

fix checkstyle warnings
project-tsurugi · Nov 13, 2023 · 0261b68 · 0261b68
2 parents 7f13da8 + a700981
commit 0261b68
Show file tree

Hide file tree

Showing 10 changed files with 16 additions and 16 deletions.
diff --git a/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/BasicPutGetRemoveTest.java b/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/BasicPutGetRemoveTest.java
@@ -17,7 +17,7 @@ class BasicPutGetRemoveTest extends TestBase {
     private static final String KEY_NAME = "k1";
     private static final String VALUE_NAME = "v1";
 
-    public BasicPutGetRemoveTest() throws Exception {
+    BasicPutGetRemoveTest() throws Exception {
         String schema = String.format("%s BIGINT PRIMARY KEY, %s BIGINT", KEY_NAME, VALUE_NAME);
         createTable(TABLE_NAME, schema);
     }

diff --git a/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/CommitTest.java b/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/CommitTest.java
@@ -19,7 +19,7 @@ class CommitTest extends TestBase {
     private static final String KEY_NAME = "k1";
     private static final String VALUE_NAME = "v1";
 
-    public CommitTest() throws Exception {
+    CommitTest() throws Exception {
         String schema = String.format("%s BIGINT PRIMARY KEY, %s BIGINT", KEY_NAME, VALUE_NAME);
         createTable(TABLE_NAME, schema);
     }

diff --git a/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/GetTest.java b/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/GetTest.java
@@ -17,7 +17,7 @@ class GetTest extends TestBase {
     private static final String KEY_NAME = "k1";
     private static final String VALUE_NAME = "v1";
 
-    public GetTest() throws Exception {
+    GetTest() throws Exception {
         String schema = String.format("%s BIGINT PRIMARY KEY, %s BIGINT", KEY_NAME, VALUE_NAME);
         createTable(TABLE_NAME, schema);
     }
@@ -30,7 +30,7 @@ public void invalidRequests() throws Exception {
             // COLUMN_TYPE_MISMATCH
             try (var tx = kvs.beginTransaction().await()) {
                 key.clear();
-                key.add(KEY_NAME, (int)key1);
+                key.add(KEY_NAME, (int) key1);
                 KvsServiceException ex = assertThrows(KvsServiceException.class,
                         () -> kvs.get(tx, TABLE_NAME, key).await());
                 assertEquals(KvsServiceCode.COLUMN_TYPE_MISMATCH, ex.getDiagnosticCode());

diff --git a/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/PutMultiValuesTest.java b/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/PutMultiValuesTest.java
@@ -19,7 +19,7 @@ class PutMultiValuesTest extends TestBase {
     private static final String VALUE1_NAME = "v1";
     private static final String VALUE2_NAME = "v2";
 
-    public PutMultiValuesTest() throws Exception {
+    PutMultiValuesTest() throws Exception {
         String schema = String.format("%s BIGINT PRIMARY KEY, %s BIGINT, %s BIGINT", KEY_NAME, VALUE1_NAME,
                 VALUE2_NAME);
         createTable(TABLE_NAME, schema);

diff --git a/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/PutTest.java b/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/PutTest.java
@@ -18,7 +18,7 @@ class PutTest extends TestBase {
     private static final String KEY_NAME = "k1";
     private static final String VALUE_NAME = "v1";
 
-    public PutTest() throws Exception {
+    PutTest() throws Exception {
         String schema = String.format("%s BIGINT PRIMARY KEY, %s BIGINT", KEY_NAME, VALUE_NAME);
         createTable(TABLE_NAME, schema);
     }
@@ -32,7 +32,7 @@ public void invalidRequests() throws Exception {
             // COLUMN_TYPE_MISMATCH
             try (var tx = kvs.beginTransaction().await()) {
                 buffer.clear();
-                buffer.add(KEY_NAME, (int)key1);
+                buffer.add(KEY_NAME, (int) key1);
                 buffer.add(VALUE_NAME, value1);
                 KvsServiceException ex = assertThrows(KvsServiceException.class,
                         () -> kvs.put(tx, TABLE_NAME, buffer, PutType.OVERWRITE).await());
@@ -42,16 +42,16 @@ public void invalidRequests() throws Exception {
             try (var tx = kvs.beginTransaction().await()) {
                 buffer.clear();
                 buffer.add(KEY_NAME, key1);
-                buffer.add(VALUE_NAME, (int)value1);
+                buffer.add(VALUE_NAME, (int) value1);
                 KvsServiceException ex = assertThrows(KvsServiceException.class,
                         () -> kvs.put(tx, TABLE_NAME, buffer, PutType.OVERWRITE).await());
                 assertEquals(KvsServiceCode.COLUMN_TYPE_MISMATCH, ex.getDiagnosticCode());
                 kvs.rollback(tx).await();
             }
             try (var tx = kvs.beginTransaction().await()) {
                 buffer.clear();
-                buffer.add(KEY_NAME, (int)key1);
-                buffer.add(VALUE_NAME, (int)value1);
+                buffer.add(KEY_NAME, (int) key1);
+                buffer.add(VALUE_NAME, (int) value1);
                 KvsServiceException ex = assertThrows(KvsServiceException.class,
                         () -> kvs.put(tx, TABLE_NAME, buffer, PutType.OVERWRITE).await());
                 assertEquals(KvsServiceCode.COLUMN_TYPE_MISMATCH, ex.getDiagnosticCode());

diff --git a/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/RemoveTest.java b/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/RemoveTest.java
@@ -17,7 +17,7 @@ class RemoveTest extends TestBase {
     private static final String KEY_NAME = "k1";
     private static final String VALUE_NAME = "v1";
 
-    public RemoveTest() throws Exception {
+    RemoveTest() throws Exception {
         String schema = String.format("%s BIGINT PRIMARY KEY, %s BIGINT", KEY_NAME, VALUE_NAME);
         createTable(TABLE_NAME, schema);
     }
@@ -30,7 +30,7 @@ public void invalidRequests() throws Exception {
             // COLUMN_TYPE_MISMATCH
             try (var tx = kvs.beginTransaction().await()) {
                 key.clear();
-                key.add(KEY_NAME, (int)key1);
+                key.add(KEY_NAME, (int) key1);
                 KvsServiceException ex = assertThrows(KvsServiceException.class,
                         () -> kvs.remove(tx, TABLE_NAME, key).await());
                 assertEquals(KvsServiceCode.COLUMN_TYPE_MISMATCH, ex.getDiagnosticCode());

diff --git a/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/RollbackTest.java b/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/RollbackTest.java
@@ -18,7 +18,7 @@ class RollbackTest extends TestBase {
     private static final String KEY_NAME = "k1";
     private static final String VALUE_NAME = "v1";
 
-    public RollbackTest() throws Exception {
+    RollbackTest() throws Exception {
         String schema = String.format("%s BIGINT PRIMARY KEY, %s BIGINT", KEY_NAME, VALUE_NAME);
         createTable(TABLE_NAME, schema);
     }

diff --git a/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/SecondaryIndexTableTest.java b/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/SecondaryIndexTableTest.java
@@ -17,7 +17,7 @@ class SecondaryIndexTableTest extends TestBase {
     private static final String KEY_NAME = "k1";
     private static final String VALUE_NAME = "v1";
 
-    public SecondaryIndexTableTest() throws Exception {
+    SecondaryIndexTableTest() throws Exception {
         String schema = String.format("%s BIGINT PRIMARY KEY, %s BIGINT", KEY_NAME, VALUE_NAME);
         createTable(TABLE_NAME, schema);
         String sql = String.format("CREATE INDEX %s on %s(%s)", "index" + VALUE_NAME, TABLE_NAME, VALUE_NAME);

diff --git a/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/SessionClientTest.java b/modules/kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/basic/SessionClientTest.java
@@ -14,7 +14,7 @@ class SessionClientTest extends TestBase {
     private static final String KEY_NAME = "k1";
     private static final String VALUE_NAME = "v1";
 
-    public SessionClientTest() throws Exception {
+    SessionClientTest() throws Exception {
         String schema = String.format("%s BIGINT PRIMARY KEY, %s BIGINT", KEY_NAME, VALUE_NAME);
         createTable(TABLE_NAME, schema);
     }

diff --git a/...kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/compatibility/CompatMultiValuesTest.java b/...kvs/src/inttest/java/com/tsurugidb/tsubakuro/kvs/compatibility/CompatMultiValuesTest.java
@@ -13,7 +13,7 @@ class CompatMultiValuesTest extends CompatBase {
 
     private static final String TABLE_NAME = "table" + CompatMultiValuesTest.class.getSimpleName();
 
-    public CompatMultiValuesTest() throws Exception {
+    CompatMultiValuesTest() throws Exception {
         super(TABLE_NAME);
     }