Skip to content

Commit

Permalink
[docker] next set of fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
rspilker committed Sep 15, 2023
1 parent 5b872c8 commit 4d52730
Show file tree
Hide file tree
Showing 10 changed files with 16 additions and 11 deletions.
2 changes: 1 addition & 1 deletion docker/ant/files/jdk-11/classpath/build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</target>

<target name="compile" depends="init" description="compile the source">
<javac classpath="../lombok.jar" modulepath="lombok.jar" srcdir="${src}" destdir="${build}" fork="true">
<javac classpath="../lombok.jar" modulepath="../lombok.jar" srcdir="${src}" destdir="${build}" fork="true">
<compilerarg value="-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED"/>
<compilerarg value="-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED"/>
<compilerarg value="-J--add-opens=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED"/>
Expand Down
2 changes: 1 addition & 1 deletion docker/ant/files/jdk-17/classpath/build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</target>

<target name="compile" depends="init" description="compile the source">
<javac classpath="lombok.jar" modulepath="lombok.jar" srcdir="${src}" destdir="${build}" fork="true">
<javac classpath="../lombok.jar" modulepath="../lombok.jar" srcdir="${src}" destdir="${build}" fork="true">
<compilerarg value="-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED"/>
<compilerarg value="-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED"/>
<compilerarg value="-J--add-opens=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED"/>
Expand Down
2 changes: 1 addition & 1 deletion docker/ant/files/jdk-17/modules/build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</target>

<target name="compile" depends="init" description="compile the source">
<javac classpath="lombok.jar" srcdir="${src}" destdir="${build}" fork="true">
<javac classpath="../lombok.jar" srcdir="${src}" destdir="${build}" fork="true">
<compilerarg value="-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED"/>
<compilerarg value="-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED"/>
<compilerarg value="-J--add-opens=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED"/>
Expand Down
2 changes: 1 addition & 1 deletion docker/ant/files/jdk-21/classpath/build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</target>

<target name="compile" depends="init" description="compile the source">
<javac classpath="lombok.jar" modulepath="lombok.jar" srcdir="${src}" destdir="${build}" fork="true">
<javac classpath="../lombok.jar" modulepath="../lombok.jar" srcdir="${src}" destdir="${build}" fork="true">
<compilerarg value="-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED"/>
<compilerarg value="-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED"/>
<compilerarg value="-J--add-opens=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED"/>
Expand Down
2 changes: 1 addition & 1 deletion docker/ant/files/jdk-21/modules/build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</target>

<target name="compile" depends="init" description="compile the source">
<javac classpath="lombok.jar" srcdir="${src}" destdir="${build}" fork="true">
<javac classpath="../lombok.jar" srcdir="${src}" destdir="${build}" fork="true">
<compilerarg value="-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED"/>
<compilerarg value="-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED"/>
<compilerarg value="-J--add-opens=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED"/>
Expand Down
2 changes: 1 addition & 1 deletion docker/gradle/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ RUN provision/jdk/java-${jdk}.sh
ARG lombokjar=lombok.jar
ADD https://projectlombok.org/downloads/${lombokjar} /lombok.jar

ARG gradle=7.6.1
ARG gradle=8.3
ADD provision/gradle/gradle-${gradle}.sh provision/gradle/gradle-${gradle}.sh
RUN provision/gradle/gradle-${gradle}.sh

Expand Down
7 changes: 4 additions & 3 deletions docker/gradle/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@

[_(general configuration and options)_](../readme.md)

### `ARG gradle=7.6.1`
### `ARG gradle=8.3`

The gradle version to be used. Supported values:

- `7.6.1` (default)
- `8.3` (default)
- `7.6.1`
- `6.8.3`

## Example build commands:
Expand All @@ -16,7 +17,7 @@ The gradle version to be used. Supported values:
```
docker build -t lombok-gradle-jdk17 -f gradle/Dockerfile .
docker build -t lombok-gradle-jdk17 --build-arg lombokjar=lombok-1.18.20.jar -f gradle/Dockerfile .
docker build -t lombok-gradle-jdk17 --build-arg lombokjar=lombok-1.18.28.jar -f gradle/Dockerfile .
```

## Example run commands:
Expand Down
2 changes: 1 addition & 1 deletion docker/maven/files/jdk-21/classpath/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.9.0</version>
<version>3.11.0</version>
<configuration>
<source>${java.version}</source>
<target>${java.version}</target>
Expand Down
2 changes: 1 addition & 1 deletion docker/maven/files/jdk-21/modules/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.9.0</version>
<version>3.11.0</version>
<configuration>
<source>${java.version}</source>
<target>${java.version}</target>
Expand Down
4 changes: 4 additions & 0 deletions docker/provision/gradle/gradle-8.3.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
apt-get update && apt-get install -y wget unzip
wget https://services.gradle.org/distributions/gradle-8.3-bin.zip -O gradle.zip
mkdir /opt/gradle && unzip -d /opt/gradle gradle.zip
mv /opt/gradle/gradle-8.3 /opt/gradle/gradle

0 comments on commit 4d52730

Please sign in to comment.