Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve content of intro_tutorial #1697

Merged
merged 3 commits into from
May 15, 2023
Merged

Improve content of intro_tutorial #1697

merged 3 commits into from
May 15, 2023

Conversation

rht
Copy link
Contributor

@rht rht commented May 15, 2023

Basically, #1665 but onto main instead.

Fixes #1661.

glnnlhmn and others added 3 commits May 15, 2023 04:24
- add background information,
- add model-specific information
- add technical information
- update code comments
- update exercise 1
- delete .rst and .pngs due to addition of nbsphinx

Co-authored-by: rht <[email protected]>
Co-authored-by: tpike3 <[email protected]>
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (02592f3) 81.49% compared to head (96fc2e4) 81.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1697   +/-   ##
=======================================
  Coverage   81.49%   81.49%           
=======================================
  Files          18       18           
  Lines        1405     1405           
  Branches      273      273           
=======================================
  Hits         1145     1145           
  Misses        214      214           
  Partials       46       46           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. This contain a lot of great improvements from process (nbsphinx) to clarity (better explanations) Thanks @glnnlhmn and @rht.

@tpike3 tpike3 merged commit 68b8e6c into main May 15, 2023
@tpike3 tpike3 added this to the Mesa 2.0 (Wellton) milestone Jul 1, 2023
@jackiekazil jackiekazil deleted the doc_builds branch May 20, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix codespell build for tutorial docs
3 participants