Add kube_version variable to ensure helm renders manifests correctly #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Docs update would be nice, you can steal the text from https://github.com/projectsyn/component-cilium/blob/a11f40e3ced838c8f51b5aac46678c3aa80e5480/docs/modules/ROOT/pages/references/parameters.adoc?plain=1#L45-L54
TheBigLee
force-pushed
the
configurable_k8s_version
branch
from
6cd45ad
to
7e18cf9
Compare
simu
reviewed
Sep 3, 2024
We need to set the kube_version helm parameter in order to ensure that commodore will render the manifests for the correct kubernetes version Signed-off-by: Nicolas Bigler <[email protected]>
TheBigLee
force-pushed
the
configurable_k8s_version
branch
from
4706c5f
to
b39e2f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to set the kube_version helm parameter in order to ensure that commodore will render the manifests for the correct kubernetes version
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.