Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust crate pyo3 to v0.23.1 #142

Merged
merged 2 commits into from
Nov 19, 2024

Update codebase to not use methods deprecated in PyO3 0.23

9dc569d
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Update Rust crate pyo3 to v0.23.1 #142

Update codebase to not use methods deprecated in PyO3 0.23
9dc569d
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Nov 19, 2024 in 0s

clippy

3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 3
Note 0
Help 0

Versions

  • rustc 1.82.0 (f6e511eec 2024-10-15)
  • cargo 1.82.0 (8f40fc59f 2024-08-21)
  • clippy 0.1.82 (f6e511e 2024-10-15)

Annotations

Check warning on line 208 in src/node/nodeinfo.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `pyo3::Bound<'_, pyo3::types::PyDict>` 

warning: useless conversion to the same type: `pyo3::Bound<'_, pyo3::types::PyDict>`
   --> src/node/nodeinfo.rs:208:12
    |
208 |         Ok(dict.into())
    |            ^^^^^^^^^^^ help: consider removing `.into()`: `dict`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 190 in src/node/nodeinfo.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `pyo3::Bound<'_, pyo3::types::PyDict>` 

warning: useless conversion to the same type: `pyo3::Bound<'_, pyo3::types::PyDict>`
   --> src/node/nodeinfo.rs:190:12
    |
190 |         Ok(dict.into())
    |            ^^^^^^^^^^^ help: consider removing `.into()`: `dict`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 93 in src/inventory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `pyo3::Bound<'_, pyo3::types::PyDict>` 

warning: useless conversion to the same type: `pyo3::Bound<'_, pyo3::types::PyDict>`
  --> src/inventory.rs:93:12
   |
93 |         Ok(dict.into())
   |            ^^^^^^^^^^^ help: consider removing `.into()`: `dict`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
   = note: `#[warn(clippy::useless_conversion)]` on by default
View more details on GitHub Actions