Skip to content

Commit

Permalink
remove TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
lmd59 committed Jun 13, 2024
1 parent d4a55ee commit 0246397
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion service/src/services/BaseService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ async function uploadResourcesFromBundle(entries: DetailedEntry[]) {
* Inserts Library or Measure resources from Bundle into the database through create or update.
*/
async function insertBundleResources(entry: DetailedEntry) {
// TODO: make updates here for AUHTHORING/PUBLISHABLE
if (entry.resource?.resourceType === 'Library' || entry.resource?.resourceType === 'Measure') {
if (entry.isPost) {
checkFieldsForCreate(entry.resource);
Expand Down
1 change: 0 additions & 1 deletion service/src/util/inputUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ export function checkFieldsForUpdate(
) {
if (process.env.AUTHORING !== 'true' || oldResource.status === 'active') {
// publishable or active status requires retire functionality
// TODO: is there any other metadata we should allow to update for the retire functionality?
if (process.env.AUTHORING !== 'true' && oldResource.status !== 'active') {
throw new BadRequestError(
`Resource status is currently ${oldResource.status}. Publishable repository service updates may only be made to active status resources.`
Expand Down

0 comments on commit 0246397

Please sign in to comment.