add comment on string for POST validation

projecttacoma · Oct 4, 2024 · 5e69f96 · 5e69f96
1 parent 9c2462e
commit 5e69f96
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/service/src/requestSchemas.ts b/service/src/requestSchemas.ts
@@ -207,7 +207,7 @@ export const ApproveArgs = z
     artifactAssessmentRelatedArtifact: checkUri.optional(),
     artifactAssessmentAuthor: z
       .union([z.object({ reference: z.string() }).transform(val => val.reference), z.string()])
-      .optional() //object from POST or string from GET
+      .optional() //object from POST or string from GET (this may be overly permissive of string in POST parameters)
   })
   .strict()
   .superRefine(catchInvalidParams([catchMissingId, catchMissingTypeAndSummary]));
@@ -224,7 +224,7 @@ export const ReviewArgs = z
     artifactAssessmentRelatedArtifact: checkUri.optional(),
     artifactAssessmentAuthor: z
       .union([z.object({ reference: z.string() }).transform(val => val.reference), z.string()])
-      .optional() //object from POST or string from GET
+      .optional() //object from POST or string from GET (this may be overly permissive of string in POST parameters)
   })
   .strict()
   .superRefine(catchInvalidParams([catchMissingId, catchMissingTypeAndSummary]));