Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(node_exporter): use systemd to create node_exporter_textfile_dir if it doesn't exist #323

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

enhancement(node_exporter): use systemd to create node_exporter_textfile_dir if it doesn't exist #323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions roles/node_exporter/templates/node_exporter.service.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@ After=network-online.target
Type=simple
User={{ node_exporter_system_user }}
Group={{ node_exporter_system_group }}
{% if node_exporter_textfile_dir | length > 0 %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would affect the common user who does not use tmpfs.

{% if (ansible_facts.packages.systemd | first).version is version('235', '>=') %}
ExecStartPre=+/bin/mkdir -p {{ node_exporter_textfile_dir }}
ExecStartPre=+/bin/chown -R {{ node_exporter_system_user }}:{{ node_exporter_system_group }} {{ node_exporter_textfile_dir }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I wonder if this should be -R. I'm not sure we want all of the prom files changed, just the dir.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our environment, the text file exporters are started after node_exporter.service and the directory is used exclusively for text file exporters, so it doesn't really matter, but I think we can remove the -R, or should we go further and only change the owner if the directory is empty?

{% else %}
ExecStartPre=/bin/mkdir -p {{ node_exporter_textfile_dir }}
ExecStartPre=/bin/chown -R {{ node_exporter_system_user }}:{{ node_exporter_system_group }} {{ node_exporter_textfile_dir }}
PermissionsStartOnly=true
{% endif %}
{% endif %}
ExecStart={{ node_exporter_binary_install_dir }}/node_exporter \
{% for collector in node_exporter_enabled_collectors -%}
{% if not collector is mapping %}
Expand Down
Loading