Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: New 24199687 upstream release 0.10.2! #475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

The upstream 24199687 released new software version - 0.10.2!

This automated PR updates code to bring new version into repository.

@SuperQ
Copy link
Contributor

SuperQ commented Nov 21, 2024

I guess we need better handling of the gitlab project updates.

@mgariepy
Copy link

mgariepy commented Dec 2, 2024

anyone can fix this ? the same issue blocks #474

for the latest release gitlab does do a 308 redirect that doesn't seems to be handled correctly by older version of python (<3.11) #474 (comment)

@gardar
Copy link
Member

gardar commented Dec 4, 2024

Since the issue seems to be that urllib in older python versions does not handle 308 redirects I wonder if changing the follow_redirects option for the url lookup would have any effect.
https://docs.ansible.com/ansible/latest/collections/ansible/builtin/url_lookup.html#parameter-follow_redirects or if we can avoid that redirect somehow by updating the checksum url

@mgariepy
Copy link

mgariepy commented Dec 4, 2024

Since the issue seems to be that urllib in older python versions does not handle 308 redirects I wonder if changing the follow_redirects option for the url lookup would have any effect. https://docs.ansible.com/ansible/latest/collections/ansible/builtin/url_lookup.html#parameter-follow_redirects or if we can avoid that redirect somehow by updating the checksum url

from a quick tests it doesn't work with ansible.builtin.get_url when running ansible 2.14.0 on python 3.10.12 (from jammy utuntu python). Also the options was added on 2.10 so 2.9 would need to be bumped a bit.

@mgariepy
Copy link

mgariepy commented Dec 4, 2024

Since the issue seems to be that urllib in older python versions does not handle 308 redirects I wonder if changing the follow_redirects option for the url lookup would have any effect. https://docs.ansible.com/ansible/latest/collections/ansible/builtin/url_lookup.html#parameter-follow_redirects or if we can avoid that redirect somehow by updating the checksum url

from a quick tests it doesn't work with ansible.builtin.get_url when running ansible 2.14.0 on python 3.10.12 (from jammy utuntu python). Also the options was added on 2.10 so 2.9 would need to be bumped a bit.

Also it's a gitlab.com issue here with the double '/' in the 302 redirect. would be better to have them fix the 302.

@mgariepy
Copy link

mgariepy commented Dec 5, 2024

just created an issue concerning the gitlab problem: https://gitlab.com/gitlab-org/gitlab/-/issues/508161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants