Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use lookup for console template test #481

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Nov 27, 2024

When deploying the console templates, use a local lookup to check if the Prometheus tarball contains consoles to deploy.

When deploying the console templates, use a local lookup
to check if the Prometheus tarball contains consoles to deploy.

Signed-off-by: SuperQ <[email protected]>
@maximepoulin-hl
Copy link

I'm surprised when: prometheus_version is version('3.0.0', '<') didn't work, I had that explicitly set to 3.0.0 in #478 so I'm not sure why I still ended up running that task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants