Skip to content

Commit

Permalink
[prometheus-smartctl-exporter] Don't use hostNetwork (#4964)
Browse files Browse the repository at this point in the history
* Don't use `hostNetwork`

Signed-off-by: GitHub <[email protected]>

* Bump chart version

Signed-off-by: GitHub <[email protected]>

* Make `hostNetwork` configurable

Signed-off-by: Judah Rand <[email protected]>

* Bump minor version instead

Signed-off-by: GitHub <[email protected]>

---------

Signed-off-by: GitHub <[email protected]>
Signed-off-by: Judah Rand <[email protected]>
  • Loading branch information
judahrand authored Nov 5, 2024
1 parent 4c7d768 commit d0cbf1b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion charts/prometheus-smartctl-exporter/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.10.0
version: 0.11.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
4 changes: 2 additions & 2 deletions charts/prometheus-smartctl-exporter/templates/daemonset.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- $global := . }}
{{- $base := dict "annotations" .Values.annotations "resources" .Values.resources "nodeSelector" .Values.nodeSelector "affinity" .Values.affinity "tolerations" .Values.tolerations "config" .Values.config }}
{{- $base := dict "annotations" .Values.annotations "resources" .Values.resources "nodeSelector" .Values.nodeSelector "affinity" .Values.affinity "tolerations" .Values.tolerations "config" .Values.config "hostNetwork" .Values.hostNetwork }}
{{- $items := prepend .Values.extraInstances $base }}
{{- range $idx, $item := $items }}
{{- $config := mergeOverwrite $item.config $global.Values.common.config }}
Expand Down Expand Up @@ -60,7 +60,7 @@ spec:
- mountPath: /hostdev
name: dev
dnsPolicy: ClusterFirst
hostNetwork: true
hostNetwork: {{ $item.hostNetwork }}
restartPolicy: Always
serviceAccountName: {{ template "prometheus-smartctl-exporter.fullname" $global }}
volumes:
Expand Down
2 changes: 2 additions & 0 deletions charts/prometheus-smartctl-exporter/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ resources: {}
# cpu: 100m
# memory: 128Mi

hostNetwork: false

annotations: {}

nodeSelector: {}
Expand Down

0 comments on commit d0cbf1b

Please sign in to comment.