Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-pushgateway] Support lifecycle hooks #5102

Closed
duncaan opened this issue Dec 29, 2024 · 0 comments · Fixed by #5103
Closed

[prometheus-pushgateway] Support lifecycle hooks #5102

duncaan opened this issue Dec 29, 2024 · 0 comments · Fixed by #5103
Labels
enhancement New feature or request

Comments

@duncaan
Copy link
Contributor

duncaan commented Dec 29, 2024

Is your feature request related to a problem ?

I'm not able to add a pre-stop hook to the push-gateway deployment.

Describe the solution you'd like.

I would like to be able to add a sleep to the pods before being terminated.

Describe alternatives you've considered.

I can manually add this to the deployment, but I would like to keep this in source control.

Additional context.

No response

@duncaan duncaan added the enhancement New feature or request label Dec 29, 2024
duncaan added a commit to duncaan/helm-charts that referenced this issue Dec 29, 2024
Fixes prometheus-community#5102

Add support for lifecycle hooks in the push-gateway deployment.

* Add lifecycle hooks configuration to `charts/prometheus-pushgateway/templates/deployment.yaml`
* Add lifecycle hooks configuration to `charts/prometheus-pushgateway/templates/statefulset.yaml`
* Add lifecycle hooks configuration options in `charts/prometheus-pushgateway/values.yaml`

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/prometheus-community/helm-charts/issues/5102?shareId=XXXX-XXXX-XXXX-XXXX).
duncaan added a commit to duncaan/helm-charts that referenced this issue Dec 29, 2024
Fixes prometheus-community#5102

Add support for lifecycle hooks in the push-gateway deployment.

* Add lifecycle hooks configuration to `charts/prometheus-pushgateway/templates/deployment.yaml`
* Add lifecycle hooks configuration to `charts/prometheus-pushgateway/templates/statefulset.yaml`
* Add lifecycle hooks configuration options in `charts/prometheus-pushgateway/values.yaml`

Signed-off-by: Duncan Schulze <[email protected]>
@zeritti zeritti changed the title [prometheus-push-gateway] Support lifecycle hooks [prometheus-pushgateway] Support lifecycle hooks Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant