Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-push-gateway] Add lifecycle hooks #5103

Merged
merged 4 commits into from
Dec 31, 2024

Conversation

duncaan
Copy link
Contributor

@duncaan duncaan commented Dec 29, 2024

Fixes #5102

Add support for lifecycle hooks in the push-gateway deployment.

  • Add lifecycle hooks configuration to charts/prometheus-pushgateway/templates/deployment.yaml
  • Add lifecycle hooks configuration to charts/prometheus-pushgateway/templates/statefulset.yaml
  • Add lifecycle hooks configuration options in charts/prometheus-pushgateway/values.yaml

For more details, open the Copilot Workspace session.

Fixes prometheus-community#5102

Add support for lifecycle hooks in the push-gateway deployment.

* Add lifecycle hooks configuration to `charts/prometheus-pushgateway/templates/deployment.yaml`
* Add lifecycle hooks configuration to `charts/prometheus-pushgateway/templates/statefulset.yaml`
* Add lifecycle hooks configuration options in `charts/prometheus-pushgateway/values.yaml`

Signed-off-by: Duncan Schulze <[email protected]>
@duncaan duncaan force-pushed the add-lifecycle-hooks branch from e7036be to aeea100 Compare December 29, 2024 22:12
Copy link
Member

@zeritti zeritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @duncaan, for your PR. Please, see my comments below.

charts/prometheus-pushgateway/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/prometheus-pushgateway/templates/statefulset.yaml Outdated Show resolved Hide resolved
Signed-off-by: Duncan Schulze <[email protected]>
@duncaan duncaan requested a review from zeritti December 30, 2024 15:57
Copy link
Member

@zeritti zeritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes. I did not immediately realise then that podSpec was defined in the helper template prometheus-pushgateway.podSpec in _helpers.tpl. The lifecycle field has to go in there.

Copy link
Member

@zeritti zeritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placement of the lifecycle field has been corrected, a test case is included.

@zeritti zeritti merged commit da39668 into prometheus-community:main Dec 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prometheus-pushgateway] Support lifecycle hooks
2 participants