-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prometheus-push-gateway] Add lifecycle hooks #5103
[prometheus-push-gateway] Add lifecycle hooks #5103
Conversation
Fixes prometheus-community#5102 Add support for lifecycle hooks in the push-gateway deployment. * Add lifecycle hooks configuration to `charts/prometheus-pushgateway/templates/deployment.yaml` * Add lifecycle hooks configuration to `charts/prometheus-pushgateway/templates/statefulset.yaml` * Add lifecycle hooks configuration options in `charts/prometheus-pushgateway/values.yaml` Signed-off-by: Duncan Schulze <[email protected]>
e7036be
to
aeea100
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @duncaan, for your PR. Please, see my comments below.
Signed-off-by: Duncan Schulze <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes. I did not immediately realise then that podSpec was defined in the helper template prometheus-pushgateway.podSpec
in _helpers.tpl
. The lifecycle field has to go in there.
Signed-off-by: zeritti <[email protected]>
Signed-off-by: zeritti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Placement of the lifecycle field has been corrected, a test case is included.
Fixes #5102
Add support for lifecycle hooks in the push-gateway deployment.
charts/prometheus-pushgateway/templates/deployment.yaml
charts/prometheus-pushgateway/templates/statefulset.yaml
charts/prometheus-pushgateway/values.yaml
For more details, open the Copilot Workspace session.