[prometheus-json-exporter] Add default action to ServiceMonitor #4591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yahel2410 <[email protected]>
yahel2410
force-pushed
the
json-exporter-add-action-replace
branch
from
74952bc to
687e9a3
Compare
zanhsieh
approved these changes
Jun 8, 2024
nerzhul
pushed a commit
to nerzhul/helm-charts
that referenced
this pull request
Jun 9, 2024
…etheus-community#4591) Signed-off-by: yahel2410 <[email protected]> Co-authored-by: MH <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Add the default
action: replaceto ServiceAccount.Otherwise ArgoCD shows constant diff on the ServiceAccount resource. See image
Checklist
[prometheus-couchdb-exporter])