[prom-label-proxy] kube-rbac-proxy support #4624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkroepke
requested changes
Jun 29, 2024
There was a problem hiding this comment.
Hi @sathieu
could you please add a ci test values files like main/charts/jiralert/ci/test-values.yaml where a full blown configuration for rbac-proxy exists? Then, everything is covered inside CI
sathieu
force-pushed
the
prom-label-proxy_kube-rbac-proxy
branch
from
3e0191f to
40f5a5b
Compare
Signed-off-by: Mathieu Parent <[email protected]>
sathieu
force-pushed
the
prom-label-proxy_kube-rbac-proxy
branch
from
40f5a5b to
cf2d25a
Compare
|
@jkroepke I've added |
jkroepke
reviewed
Jul 6, 2024
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Add kube-rbac-proxy support to prom-label-proxy.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])