Skip to content

Commit

Permalink
appease the linter and clear todos
Browse files Browse the repository at this point in the history
Signed-off-by: gotjosh <[email protected]>
  • Loading branch information
gotjosh committed Oct 12, 2023
1 parent db571c2 commit b1bfa40
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
1 change: 0 additions & 1 deletion notify/notify.go
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,6 @@ func (n SetNotifiesStage) Exec(ctx context.Context, l log.Logger, alerts ...*typ

type timeStage struct {
muter types.TimeMuter
//Times map[string][]timeinterval.TimeInterval
}

type TimeMuteStage timeStage
Expand Down
2 changes: 2 additions & 0 deletions timeinterval/timeinterval.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ import (
"gopkg.in/yaml.v2"
)

// Intervener determines whether a given time and active route time interval should mute outgoing notifications.
// It implements the TimeMuter interface.
type Intervener struct {
intervals map[string][]TimeInterval
}
Expand Down
3 changes: 1 addition & 2 deletions types/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -381,9 +381,8 @@ type Muter interface {
Mutes(model.LabelSet) bool
}

// TODO
// TimeMuter determines if alerts should be muted based on the specified current time and active time interval on the route.
type TimeMuter interface {
//TODO: I don't think this should return an error but let's keep it consistent for now.
Mutes(timeIntervalName []string, now time.Time) (bool, error)
}

Expand Down

0 comments on commit b1bfa40

Please sign in to comment.