Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Github Actions publish #3532

Closed
wants to merge 2 commits into from
Closed

Fix Github Actions publish #3532

wants to merge 2 commits into from

Conversation

gotjosh
Copy link
Member

@gotjosh gotjosh commented Sep 21, 2023

No description provided.

@gotjosh gotjosh marked this pull request as ready for review September 21, 2023 17:32
@gotjosh
test
0ca91fe 
Signed-off-by: gotjosh <[email protected]>
@jan--f
Copy link
Contributor

jan--f commented Sep 22, 2023 •
edited
Loading

Since we don't use the promci build action we need to call the save_artifacts action. I think after this step should be the right place.
Apologies, I thought I had added that, I might have rebased it away at some point.

Actually scratch that, needs also crossbuilds and such.

@jan--f
Copy link
Contributor

jan--f commented Sep 22, 2023

@gotjosh see #3533

@gotjosh gotjosh closed this Oct 12, 2023
@gotjosh gotjosh deleted the test-gha branch October 12, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gotjosh @jan--f